Skip to content

Fix CI builds #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

adityapatwardhan
Copy link
Member

Fixes #13

  • Do not upload artifacts for PR builds
  • Fix yml issues
  • Separate out artifacts upload task

Write-Host "##vso[artifact.upload containerfolder=artifacts;artifactname=artifacts]$(System.ArtifactsDirectory)\Packages\$(buildName)-symbols.zip"
displayName: Upload artifacts
condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still no newline at the end of the file

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan merged commit 047f132 into PowerShell:master Oct 4, 2018
@adityapatwardhan adityapatwardhan deleted the CIArtifactsPR branch October 4, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants